Skip to content

Conversation

@biswapanda
Copy link
Contributor

@biswapanda biswapanda commented Jun 17, 2025

Overview:

Switch the Dynamo API store and operator to use NVIDIA-approved distroless containers
API store: https://catalog.ngc.nvidia.com/orgs/nvidia/teams/distroless/containers/python
Operator: https://catalog.ngc.nvidia.com/orgs/nvidia/teams/distroless/containers/go

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

  • Chores
    • Updated the build configuration to allow customization of the Docker base image during deployment.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 17, 2025

Walkthrough

The Earthfile for the operator's Docker build was updated to introduce a configurable BASE_IMAGE argument, defaulting to a specific hardened distroless Go image. The FROM directive now references this argument, allowing the base image to be overridden during the build process.

Changes

File(s) Change Summary
deploy/cloud/operator/Earthfile Made the base image configurable via a BASE_IMAGE argument with a new default; updated FROM usage.

Poem

A hop and a skip, a Docker delight,
Now our base image takes flight!
With arguments set, the build’s more spry—
Override with ease, just give it a try.
Earthfile’s more nimble, the future is bright,
Rabbits rejoice in this flexible sight! 🐇


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
deploy/cloud/operator/Earthfile (1)

45-48: Consider copying as non-root for extra hardening

You already drop privileges after the copy, but you can avoid ever running as root in the final image:

-    FROM $BASE_IMAGE
-    WORKDIR /
-    COPY +build/manager .
-    USER 65532:65532
+    FROM $BASE_IMAGE
+    USER 65532:65532
+    WORKDIR /
+    COPY --chown=65532:65532 +build/manager .

This keeps file ownership consistent and removes a brief root window.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4abab20 and 9307cf1.

📒 Files selected for processing (1)
  • deploy/cloud/operator/Earthfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: copyright-checks
  • GitHub Check: pre-commit
  • GitHub Check: Build and Test - vllm
🔇 Additional comments (1)
deploy/cloud/operator/Earthfile (1)

43-45: Verify builder compatibility with ARG in FROM

Referencing $BASE_IMAGE in FROM requires BuildKit/Docker ≥ 17.05 (Earthly follows Docker’s parser). Ensure all CI/CD and local builder environments meet this minimum; otherwise the target will fail to build.

@hhzhang16 hhzhang16 self-assigned this Jun 25, 2025
@hhzhang16 hhzhang16 changed the title fix: switch operator to use approved distroless container fix: switch operator and api store to use approved distroless containers Jun 25, 2025
Copy link
Contributor

@julienmancuso julienmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't merge without ci/gitlab/gitlab-master.nvidia.com passing

@hhzhang16 hhzhang16 merged commit 3b62692 into main Jun 30, 2025
10 of 11 checks passed
@hhzhang16 hhzhang16 deleted the bis/dep-188-operator-distroless branch June 30, 2025 20:31
atchernych pushed a commit that referenced this pull request Jul 9, 2025
…ers (#1570)

Co-authored-by: Hannah Zhang <hannahz@nvidia.com>
Co-authored-by: hhzhang16 <54051230+hhzhang16@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants