-
Notifications
You must be signed in to change notification settings - Fork 693
fix: switch operator and api store to use approved distroless containers #1570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Earthfile for the operator's Docker build was updated to introduce a configurable Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
deploy/cloud/operator/Earthfile (1)
45-48: Consider copying as non-root for extra hardeningYou already drop privileges after the copy, but you can avoid ever running as root in the final image:
- FROM $BASE_IMAGE - WORKDIR / - COPY +build/manager . - USER 65532:65532 + FROM $BASE_IMAGE + USER 65532:65532 + WORKDIR / + COPY --chown=65532:65532 +build/manager .This keeps file ownership consistent and removes a brief root window.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
deploy/cloud/operator/Earthfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: copyright-checks
- GitHub Check: pre-commit
- GitHub Check: Build and Test - vllm
🔇 Additional comments (1)
deploy/cloud/operator/Earthfile (1)
43-45: Verify builder compatibility withARGinFROMReferencing
$BASE_IMAGEinFROMrequires BuildKit/Docker ≥ 17.05 (Earthly follows Docker’s parser). Ensure all CI/CD and local builder environments meet this minimum; otherwise the target will fail to build.
julienmancuso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't merge without ci/gitlab/gitlab-master.nvidia.com passing
…ers (#1570) Co-authored-by: Hannah Zhang <hannahz@nvidia.com> Co-authored-by: hhzhang16 <54051230+hhzhang16@users.noreply.github.com>
Overview:
Switch the Dynamo API store and operator to use NVIDIA-approved distroless containers
API store: https://catalog.ngc.nvidia.com/orgs/nvidia/teams/distroless/containers/python
Operator: https://catalog.ngc.nvidia.com/orgs/nvidia/teams/distroless/containers/go
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit