Skip to content

Conversation

@tanmayv25
Copy link
Contributor

@tanmayv25 tanmayv25 commented Jun 17, 2025

Overview:

For some longer prompts, the differing cache_transceiver configs can lead to this error:

[TensorRT-LLM][ERROR] Exception in DataRequester request(): Message truncated

Removing cache_transceiver_config can assist in selecting the correct defaults by TRTLLM library.

Summary by CodeRabbit

  • Chores
    • Updated configuration files to increase available GPU memory allocation for cache from 40% to 75%.
    • Removed cache transceiver settings related to maximum token count from server configurations.

@tanmayv25 tanmayv25 enabled auto-merge (squash) June 17, 2025 21:43
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 17, 2025

Walkthrough

The configuration files for both disaggregated and router-based single-node setups were updated. The free_gpu_memory_fraction parameter in the kv_cache_config sections for context_servers and generation_servers was increased from 0.40 to 0.75, and the cache_transceiver_config subsection was removed from both server configurations.

Changes

File(s) Change Summary
examples/tensorrt_llm/configs/llmapi_disagg_configs/single_node_config.yaml
examples/tensorrt_llm/configs/llmapi_disagg_router_configs/single_node_config.yaml
Increased free_gpu_memory_fraction in kv_cache_config from 0.40 to 0.75 and removed cache_transceiver_config section from context_servers and generation_servers.

Poem

A tweak to the configs, a hop in my stride,
More GPU for caching, no tokens to hide.
Old transceivers removed, the settings are neat,
With memory more free, our servers compete!
🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4abab20 and 774ac94.

📒 Files selected for processing (2)
  • examples/tensorrt_llm/configs/llmapi_disagg_configs/single_node_config.yaml (2 hunks)
  • examples/tensorrt_llm/configs/llmapi_disagg_router_configs/single_node_config.yaml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Mirror Repository to GitLab
  • GitHub Check: Build and Test - vllm
🔇 Additional comments (2)
examples/tensorrt_llm/configs/llmapi_disagg_configs/single_node_config.yaml (1)

33-33: Validate memory config & default token limits after removal
kv_cache_config.free_gpu_memory_fraction was increased to 0.75 and the cache_transceiver_config block (with custom max_num_tokens) was removed. Confirm that TRTLLM’s defaults (≥10240 tokens for context, ≥256 for generation) cover your longest prompts without triggering truncation, and benchmark GPU memory usage under peak load to avoid OOMs or contention.

examples/tensorrt_llm/configs/llmapi_disagg_router_configs/single_node_config.yaml (1)

33-33: Validate memory config & default token limits in router flow
The free_gpu_memory_fraction is now 0.75 for both context and generation servers, and cache_transceiver_config has been removed. Verify that TRTLLM’s built-in token limits handle your longest prompts without “Message truncated” errors and test memory headroom under full router load to prevent OOMs.

Also applies to: 51-51


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants