-
Notifications
You must be signed in to change notification settings - Fork 676
feat: Unnormalize waiting requests + predictive load updates for Python router (mirroring Rust) + softmax sampling to reduce thrashing #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Fairly high-priority KV router perf update. Makes it stable and performant across a wider range of hit rates. Still not quite up to par with round-robin in the general setting, but getting close.
Do not normalize waiting requests.
Hand-wavy intuition is as such: if
waiting_requestsis to be a proxy of the token load formax_num_batched_tokensbudget, then only the absolute deltas among workers should matter, instead of the relative deltas.Perform predictive updates of
waiting_requestsas done in Rust land.A small side-note unrelated to this PR: the predictive update of
active_kv_blocksdoes not seem to be hooked up directly to the Rust routing scheduler, which usesgpu_cache_usage_perc(not shown in plot, but normalized + predictive waiting load updates also gave unstable results)
Few more updates:
kv_total_blocks, not ISL, to make the units consistent withgpu_usage_percSummary by CodeRabbit
New Features
Refactor