fix: never sleep on the eos

[alec-flowers]

Overview:

Wasn't handling EOS properly, this caused our benchmarks to be off compared to vLLM.

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of sampling parameters in text generation, allowing valid falsy values (such as 0 or False) to be set correctly from requests. This ensures more accurate and flexible control over generation options.

[coderabbitai]

Walkthrough

The update changes how the generate method in the DecodeWorkerHandler class processes sampling parameters from incoming requests. Now, parameters with falsy but valid values (such as 0 or False) are accepted, and only those explicitly set to None are skipped. The logic for handling stop conditions is also generalized.

Changes

File(s)	Change Summary
examples/vllm/components/handlers.py	Updated parameter-setting logic in generate to skip only None values, not all falsy values; generalized stop condition handling.

Estimated code review effort

1 (~5 minutes)

Poem

A handler hopped with nimble care,
Now None alone gets filtered there.
No more skipping zeros or False—
Every value gets its due, of course!
With stop conditions handled neat,
This code is now more rabbit-complete. 🐇

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ac7e888 and fa92bce.

📒 Files selected for processing (1)

• examples/vllm/components/handlers.py (1 hunks)

🧠 Learnings (1)

examples/vllm/components/handlers.py (1)

Learnt from: ishandhanani
PR: #1626
File: lib/llm/src/preprocessor.rs:238-239
Timestamp: 2025-06-24T20:59:35.725Z
Learning: In lib/llm/src/preprocessor.rs, the sampling_options call in the preprocess_request method is placed in the common section after the match statement on request.prompt_input_type(), meaning it applies to both PromptInput::Tokens and PromptInput::Text request types.

🧰 Additional context used

🧠 Learnings (1)

examples/vllm/components/handlers.py (1)

Learnt from: ishandhanani
PR: #1626
File: lib/llm/src/preprocessor.rs:238-239
Timestamp: 2025-06-24T20:59:35.725Z
Learning: In lib/llm/src/preprocessor.rs, the sampling_options call in the preprocess_request method is placed in the common section after the match statement on request.prompt_input_type(), meaning it applies to both PromptInput::Tokens and PromptInput::Text request types.

🔇 Additional comments (2)

examples/vllm/components/handlers.py (2)

124-126: LGTM! Critical fix for EOS handling.

The change from checking falsy values to only checking for None correctly allows valid parameters like max_tokens=0 or boolean flags set to False to be applied. This fixes the EOS handling issue mentioned in the PR objectives, where previously such valid configurations were incorrectly ignored, leading to benchmark inaccuracies compared to vLLM.

---

128-130: Excellent generalization of stop conditions handling.

The generalized loop approach is much cleaner than handling specific parameters individually. Consistent with the sampling_options fix above, this ensures all valid stop condition parameters (including falsy ones) are properly applied.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.