Skip to content

Conversation

@ahinsutime
Copy link
Contributor

@ahinsutime ahinsutime commented Jul 22, 2025

Overview:

Details:

  • Removed unused dynamocomponents references from deploy/cloud/operator/config/crd/kustomization.yaml

Where should the reviewer start?

  • Only modified deploy/cloud/operator/config/crd/kustomization.yaml file.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

  • Chores
    • Cleaned up configuration by removing unused references to certain resources and patches. No user-facing changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jul 22, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

👋 Hi ahinsutime! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added the external-contribution Pull request is from an external contributor label Jul 22, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 22, 2025

Walkthrough

The change updates a Kubernetes kustomization configuration by removing references to the nvidia.com_dynamocomponents.yaml resource and its associated CA injection patch from the file. No other configuration or code changes are included.

Changes

File(s) Change Summary
deploy/cloud/operator/config/crd/kustomization.yaml Removed references to nvidia.com_dynamocomponents.yaml and its CA injection patch from resources and patches sections.

Estimated code review effort

1 (~2 minutes)

Possibly related issues

Poem

A hop and a skip through YAML fields,
Out goes a resource, no longer wields.
With patches trimmed and clutter gone,
The config’s lighter, moving on!
🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4449f3d and 1412d3c.

📒 Files selected for processing (1)
  • deploy/cloud/operator/config/crd/kustomization.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • deploy/cloud/operator/config/crd/kustomization.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - vllm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ahinsutime ahinsutime force-pushed the bugfix/2042-removed-legacy-dynamocomponents-kustomization branch from 1412d3c to 4042790 Compare July 22, 2025 06:52
Signed-off-by: insukim1994 <insu.kim@moreh.io>
@ahinsutime ahinsutime force-pushed the bugfix/2042-removed-legacy-dynamocomponents-kustomization branch from 4042790 to 9aa3560 Compare July 22, 2025 06:54
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 21, 2025
@julienmancuso julienmancuso enabled auto-merge (squash) August 21, 2025 15:00
@ahinsutime ahinsutime changed the title [bugfix] Removed legacy kustomization reference. Initial commit. fix: removed legacy kustomization reference Aug 21, 2025
@github-actions github-actions bot added the fix label Aug 21, 2025
@julienmancuso julienmancuso merged commit 923e1ee into ai-dynamo:main Aug 21, 2025
7 checks passed
hhzhang16 pushed a commit that referenced this pull request Aug 27, 2025
Signed-off-by: insukim1994 <insu.kim@moreh.io>
Co-authored-by: insukim1994 <insu.kim@moreh.io>
Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
nv-anants pushed a commit that referenced this pull request Aug 28, 2025
Signed-off-by: insukim1994 <insu.kim@moreh.io>
Co-authored-by: insukim1994 <insu.kim@moreh.io>
KrishnanPrash pushed a commit that referenced this pull request Sep 2, 2025
Signed-off-by: insukim1994 <insu.kim@moreh.io>
Co-authored-by: insukim1994 <insu.kim@moreh.io>
Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
nnshah1 pushed a commit that referenced this pull request Sep 8, 2025
Signed-off-by: insukim1994 <insu.kim@moreh.io>
Co-authored-by: insukim1994 <insu.kim@moreh.io>
Signed-off-by: nnshah1 <neelays@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contribution Pull request is from an external contributor fix size/XS Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants