Skip to content

fix: endpoint changes should be prioritized over new requests in kv scheduler #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

fix: endpoint changes should be prioritized over new requests in kv scheduler #2071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e319a
first commit
PeaBrane Jul 23, 2025
1167893
NOTE to TODO
PeaBrane Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions lib/llm/src/kv_router/scheduler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,24 +142,20 @@ impl KvScheduler {
request = tokio::select! {
biased;

new_request = request_rx.recv() => {
match new_request {
Some(new_request) => {
tracing::trace!("received request to be scheduled");
new_request
},
None => {
tracing::trace!("scheduler shutdown");
break 'outer;
}
}
}

_ = endpoints_rx.changed() => {
endpoints = endpoints_rx.borrow_and_update().clone();
pending_endpoint_update = Some(endpoints.worker_ids());
continue 'outer;
}

maybe_new_request = request_rx.recv() => {
let Some(new_request) = maybe_new_request else {
tracing::warn!("scheduler shutdown");
break 'outer;
};
tracing::trace!("received request to be scheduled");
new_request
}
};

loop {
Expand All @@ -181,6 +177,7 @@ impl KvScheduler {
request.respond(response);
continue 'outer;
}
// TODO: this is not actually hooked up
Err(KvSchedulerError::AllWorkersBusy) => {
tracing::trace!("all workers busy; waiting for more capacity");
tokio::time::sleep(Duration::from_millis(5)).await;
Expand Down
Loading