-
Notifications
You must be signed in to change notification settings - Fork 675
test: add router e2e test with mockers to per-merge ci #2073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes introduce improved error handling and logging in the KV router's Rust code, specifically for scheduler errors and event dispatch failures. Additionally, new Python end-to-end tests are added to validate the KV router's integration with mock engine instances, including process management and concurrent streaming request verification. Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant MockerProcess
participant KVRouterProcess
participant HFHub
participant Client
TestRunner->>HFHub: download_model()
HFHub-->>TestRunner: (model download success/fail)
loop For each mocker
TestRunner->>MockerProcess: start()
end
TestRunner->>KVRouterProcess: start()
loop For each concurrent request
Client->>KVRouterProcess: POST /v1/chat/completions (streaming)
KVRouterProcess->>MockerProcess: Forward request
MockerProcess-->>KVRouterProcess: Streaming response
KVRouterProcess-->>Client: Streaming response
end
TestRunner->>MockerProcess: terminate()
TestRunner->>KVRouterProcess: terminate()
Estimated code review effort🎯 4 (Complex) | ⏱️ ~35 minutes Poem
Note ⚡️ Unit Test Generation - BetaCodeRabbit's unit test generation is now available in Beta! Automatically generate comprehensive unit tests for your code changes, ensuring better test coverage and catching edge cases you might miss. Our AI analyzes your code structure and creates tests that follow best practices and your project's testing patterns. Learn more here, or just try it under ✨ Finishing Touches. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Signed-off-by: Yan Ru Pei <yanrpei@gmail.com>
Overview:
as titled
Summary by CodeRabbit
Bug Fixes
Tests
Chores