-
Notifications
You must be signed in to change notification settings - Fork 692
feat: Multimodal support for dynamo with trtllm backend #2195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
dd4fb75
Multimodal Changes for trtllm
indrajit96 983a86a
Update Multimodal process based on new trtllm PR merge
indrajit96 57c0a61
Update Readme and MM configs
indrajit96 1ece94d
Resolve mypy static errors
indrajit96 8bb2ce8
Resolve review comments
indrajit96 df63325
Resolve review comments
indrajit96 db5ae9a
Update Readme.md with trtllm PR commit ID for embeddings
indrajit96 82ea0a2
Merge branch 'main' into ibhosale_trtllm_test
indrajit96 7619064
Review Comments fixed
indrajit96 696a992
Review Comments fixed
indrajit96 0e9968d
Review Comments fixed
indrajit96 5865f65
Merge branch 'main' into ibhosale_trtllm_test
indrajit96 275c1c9
Fix typo, and update multinode script
indrajit96 d7bf316
Fix review comments on Readme.md
indrajit96 7479aa1
Merge branch 'main' into ibhosale_trtllm_test
indrajit96 0514ea1
Merge branch 'main' into ibhosale_trtllm_test
indrajit96 96edda5
Merge branch 'main' into ibhosale_trtllm_test
indrajit96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
components/backends/trtllm/engine_configs/multimodal/agg.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| tensor_parallel_size: 8 | ||
| moe_expert_parallel_size: 1 | ||
| enable_attention_dp: false | ||
| max_num_tokens: 4096 | ||
| max_batch_size: 8 | ||
| trust_remote_code: true | ||
| backend: pytorch | ||
| enable_chunked_prefill: true | ||
|
|
||
| kv_cache_config: | ||
| free_gpu_memory_fraction: 0.3 | ||
| enable_block_reuse: false | ||
|
|
||
| cache_transceiver_config: | ||
| backend: default | ||
| # NOTE: pytorch_backend_config section flattened since: https://github.com/NVIDIA/TensorRT-LLM/pull/4603 | ||
| # NOTE: overlap_scheduler enabled by default since this commit and changed | ||
| # config field from 'enable_overlap_scheduler' to 'disable_overlap_scheduler': | ||
| # https://github.com/NVIDIA/TensorRT-LLM/commit/b4e5df0ee0024eda3eeb83a6ba822245a30ab428 |
29 changes: 29 additions & 0 deletions
29
components/backends/trtllm/engine_configs/multimodal/decode.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| tensor_parallel_size: 1 | ||
| moe_expert_parallel_size: 1 | ||
| enable_attention_dp: false | ||
| max_num_tokens: 8192 | ||
| max_batch_size: 16 | ||
| trust_remote_code: true | ||
| backend: pytorch | ||
| enable_chunked_prefill: true | ||
| disable_overlap_scheduler: false | ||
| kv_cache_config: | ||
| free_gpu_memory_fraction: 0.30 | ||
| enable_block_reuse: false | ||
|
|
||
| cache_transceiver_config: | ||
| backend: default |
29 changes: 29 additions & 0 deletions
29
components/backends/trtllm/engine_configs/multimodal/llama4/decode.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| tensor_parallel_size: 8 | ||
| moe_expert_parallel_size: 1 | ||
| enable_attention_dp: false | ||
| max_num_tokens: 8192 | ||
| max_batch_size: 16 | ||
| trust_remote_code: true | ||
| backend: pytorch | ||
| enable_chunked_prefill: true | ||
| disable_overlap_scheduler: false | ||
| kv_cache_config: | ||
| free_gpu_memory_fraction: 0.30 | ||
| enable_block_reuse: false | ||
|
|
||
| cache_transceiver_config: | ||
| backend: default |
31 changes: 31 additions & 0 deletions
31
components/backends/trtllm/engine_configs/multimodal/llama4/prefill.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| tensor_parallel_size: 8 | ||
| moe_expert_parallel_size: 1 | ||
| enable_attention_dp: false | ||
| max_num_tokens: 8192 | ||
| max_batch_size: 16 | ||
| trust_remote_code: true | ||
| backend: pytorch | ||
| enable_chunked_prefill: true | ||
| # Overlap scheduler not currently supported in prefill only workers. | ||
| disable_overlap_scheduler: true | ||
|
|
||
| kv_cache_config: | ||
| free_gpu_memory_fraction: 0.30 | ||
| enable_block_reuse: false | ||
|
|
||
| cache_transceiver_config: | ||
| backend: default |
31 changes: 31 additions & 0 deletions
31
components/backends/trtllm/engine_configs/multimodal/prefill.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| tensor_parallel_size: 1 | ||
| moe_expert_parallel_size: 1 | ||
| enable_attention_dp: false | ||
| max_num_tokens: 8192 | ||
| max_batch_size: 16 | ||
| trust_remote_code: true | ||
| backend: pytorch | ||
| enable_chunked_prefill: true | ||
| # Overlap scheduler not currently supported in prefill only workers. | ||
| disable_overlap_scheduler: true | ||
|
|
||
| kv_cache_config: | ||
| free_gpu_memory_fraction: 0.30 | ||
| enable_block_reuse: false | ||
|
|
||
| cache_transceiver_config: | ||
| backend: default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.