-
Notifications
You must be signed in to change notification settings - Fork 688
fix: Update disagg configs for trtllm 1.0.0rc4 changes (release/0.4.0) #2278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le_autotuner config fixes
KrishnanPrash
approved these changes
Aug 4, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Contributor
Author
|
FYI - |
tanmayv25
approved these changes
Aug 4, 2025
dmitry-tokarev-nv
approved these changes
Aug 4, 2025
rmccorm4
added a commit
that referenced
this pull request
Aug 4, 2025
This was referenced Aug 4, 2025
rmccorm4
added a commit
that referenced
this pull request
Aug 5, 2025
jain-ria
pushed a commit
that referenced
this pull request
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
With update to TRTLLM 1.0.0rc4, various config field names and requiements have changed, this PR updates them across all example configs.
Agg configs were updated with most of these in #2217, but some of the fixes were missed in the disagg configs.
Fixes nvbugs/5430986:
cache_transceiver_configis now a required field in the YAML config to enable disaggregation.Fixes nvbugs/5431299:
kv_cache_dtypeis nowkv_cache_config.dtypeautotuner_enabledis nowenable_autotunerpytorch_weights_pathis nowspeculative_model_dir, which fixes:NOTE: I will bring these fixes back to
mainbranch quickly afterwards - focus is on release for sanity testing first.