refactor: separate pyo3 from rust in vllm connector worker leader #2344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziqifan617
requested review from
GuanLuo,
alec-flowers,
biswapanda,
grahamking,
ishandhanani,
jthomson04,
kkranen,
nnshah1,
paulhendricks,
piotrm-nvidia,
ptarasiewiczNV,
rmccorm4,
ryanolson,
tanmayv25,
tedzhouhk and
tmonty12
as code owners
ryanolson
requested changes
Aug 6, 2025
| page_size: usize, | ||
| device_id: usize, | ||
| dtype_width_bytes: usize, | ||
| kv_caches: Vec<(String, Py<PyAny>)>, |
Contributor
There was a problem hiding this comment.
Any python object should be converted to a rusty object or kept on the bindings.
We won't have pyo3 available in dynamo_llm.
ziqifan617
force-pushed
the
ziqif/connector-dev-worker-refactor
branch
from
b1a2677 to
dbbcc31
Compare
ziqifan617
changed the title
…actor Signed-off-by: Ryan Olson <ryanolson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)