-
Notifications
You must be signed in to change notification settings - Fork 692
docs: Add note for LMCache ARM support #2535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi ZichengMa! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
WalkthroughAdded a new “Platform Support” section to the LMCache Integration documentation stating LMCache integration supports only x86 and does not support ARM64. No other content or logic was changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/backends/vllm/LMCache_Integration.md (1)
14-17: Clarify architecture naming in LMCache_Integration.mdTo align with our support matrix and reduce ambiguity, please update the architecture names in components/backends/vllm/LMCache_Integration.md as follows:
• File: components/backends/vllm/LMCache_Integration.md
Lines: 14–17## Platform Support -**Important Note**: LMCache integration currently only supports x86 architecture. ARM64 is not supported at this time. +**Important Note**: LMCache integration currently supports only x86-64 (x86_64 / AMD64). +ARM64 / aarch64 (e.g., Apple Silicon, AWS Graviton) is not supported at this time.Optional follow-ups:
- Link any ARM support tracking issue here
- Note OS scope if it’s Linux-only
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
components/backends/vllm/LMCache_Integration.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: pre-merge-rust (.)
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: Build and Test - dynamo
Co-authored-by: Dmitry Tokarev <dtokarev@nvidia.com> Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
Co-authored-by: Dmitry Tokarev <dtokarev@nvidia.com>
Add note to tell users LMCache is not supporting ARM right now.
Summary by CodeRabbit