Skip to content

Conversation

@ZichengMa
Copy link
Contributor

@ZichengMa ZichengMa commented Aug 19, 2025

Add note to tell users LMCache is not supporting ARM right now.

Summary by CodeRabbit

  • Documentation
    • Added a Platform Support section to the LMCache Integration docs clarifying architecture compatibility.
    • Noted an important limitation: LMCache integration currently supports x86 only; ARM64 is not supported.
    • Positioned the note after Key Benefits and before Aggregated Serving to improve discoverability.
    • No functional changes; this update clarifies deployment expectations and helps avoid unsupported setups.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

👋 Hi ZichengMa! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added docs external-contribution Pull request is from an external contributor labels Aug 19, 2025
@ZichengMa ZichengMa enabled auto-merge (squash) August 19, 2025 19:34
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 19, 2025

Walkthrough

Added a new “Platform Support” section to the LMCache Integration documentation stating LMCache integration supports only x86 and does not support ARM64. No other content or logic was changed.

Changes

Cohort / File(s) Summary of Changes
Documentation: LMCache Integration
components/backends/vllm/LMCache_Integration.md
Inserted a Platform Support section noting x86-only support and lack of ARM64 support; placed after Key Benefits and before Aggregated Serving.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

A rabbit reads the docs with care,
“x86 today, ARM not there.”
It hops between the headings bright,
Notes the platform, sets it right.
With tidy paws and markdown neat,
This change is simple, swift, complete. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/backends/vllm/LMCache_Integration.md (1)

14-17: Clarify architecture naming in LMCache_Integration.md

To align with our support matrix and reduce ambiguity, please update the architecture names in components/backends/vllm/LMCache_Integration.md as follows:

• File: components/backends/vllm/LMCache_Integration.md
Lines: 14–17

## Platform Support

-**Important Note**: LMCache integration currently only supports x86 architecture. ARM64 is not supported at this time.
+**Important Note**: LMCache integration currently supports only x86-64 (x86_64 / AMD64).  
+ARM64 / aarch64 (e.g., Apple Silicon, AWS Graviton) is not supported at this time.

Optional follow-ups:

  • Link any ARM support tracking issue here
  • Note OS scope if it’s Linux-only
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between bf5862a and d1ddaeb.

📒 Files selected for processing (1)
  • components/backends/vllm/LMCache_Integration.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: pre-merge-rust (.)
  • GitHub Check: pre-merge-rust (lib/bindings/python)
  • GitHub Check: Build and Test - dynamo

@dmitry-tokarev-nv dmitry-tokarev-nv enabled auto-merge (squash) August 19, 2025 20:20
@dmitry-tokarev-nv dmitry-tokarev-nv merged commit b9cbee0 into ai-dynamo:main Aug 19, 2025
8 of 9 checks passed
hhzhang16 pushed a commit that referenced this pull request Aug 27, 2025
Co-authored-by: Dmitry Tokarev <dtokarev@nvidia.com>
Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
nv-anants pushed a commit that referenced this pull request Aug 28, 2025
Co-authored-by: Dmitry Tokarev <dtokarev@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs external-contribution Pull request is from an external contributor size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants