-
Notifications
You must be signed in to change notification settings - Fork 679
docs: add mermaid graph to .devcontainer/README.md, remove mount (revert). #2632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation update to .devcontainer/README.md adding a Mermaid diagram that visualizes the Dev Container workflow between a developer laptop, a Linux workstation, and a Docker container, including SSH interactions, mounted volumes, and gitconfig handling. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.devcontainer/README.md (2)
26-26: Use official naming “Dev Containers” and standardize SSH capitalizationMinor wording/brand consistency improvements.
- EXT["Dev Container Extension"] + EXT["Dev Containers Extension"]- EXT -->|"2. Dev Container:<br/>Open Folder (via ssh)"| IMAGE + EXT -->|"2. Dev Containers:<br/>Open Folder (via SSH)"| IMAGEAlso applies to: 51-51
49-50: Point SSH edges to the workstation host (not a specific directory) for accuracyArrows from Terminal and Remote-SSH to DIR suggest you SSH into a directory. More precise to target the host’s SSH service, then branch to directories/containers.
subgraph WS["Linux Workstation"] DIR["~/dynamo<br/>(host directory)"] HFCACHE["~/.cache/huggingface<br/>(host cache)"] GITCONFIG["~/.gitconfig<br/>(host git config)"] + SSHD["sshd (Linux host)"]- TERM -->|"SSH Connection"| DIR - SSHEXT -->|"1. Remote-SSH"| DIR + TERM -->|"SSH connection"| SSHD + SSHEXT -->|"1. Remote - SSH"| SSHD + SSHD --> DIR
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.devcontainer/README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Mirror Repository to GitLab
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (3)
.devcontainer/README.md (3)
22-70: Great addition: the Mermaid diagram meaningfully clarifies the devcontainer workflowThe overall structure, mounts, and the numbered flow make it much easier for newcomers to reason about the setup. Colors and subgraphs are also well used.
33-41: Confirm GitHub renders
line breaks as intended in labelsMermaid generally supports
, but GitHub’s renderer can be picky. Quick preview in the PR helps avoid run-together labels.Steps:
- Use “View file” in the PR and confirm the node labels for DIR/HFCACHE/CONTAINER/MOUNT show on multiple lines.
- If they don’t, replace
with “\n” (Mermaid supports newline escapes in some labels) or split content across separate nodes.
37-37: Update README to matchremoteUserand simplify wording
- File: .devcontainer/README.md
Line: 37- subgraph CONTAINER["Docker Container<br/>vsc-dynamo-SHA-uid<br/>Running as: ubuntu user"] + subgraph CONTAINER["Docker Container<br/>vsc-dynamo-SHA-uid<br/>Running as: ubuntu"]The
remoteUsersetting in.devcontainer/devcontainer.jsonis"ubuntu", so dropping “user” here keeps the README in sync.
57e73c8 to
6b9ba27
Compare
Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
6b9ba27 to
24c02eb
Compare
…ert). (#2632) Co-authored-by: Keiven Chang <keivenchang@users.noreply.github.com> Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
…ert). (#2632) Co-authored-by: Keiven Chang <keivenchang@users.noreply.github.com> Signed-off-by: Michael Shin <michaelshin@users.noreply.github.com>
…ert). (#2632) Co-authored-by: Keiven Chang <keivenchang@users.noreply.github.com> Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
…ert). (#2632) Co-authored-by: Keiven Chang <keivenchang@users.noreply.github.com> Signed-off-by: nnshah1 <neelays@nvidia.com>
Overview:
Remove mount. Add a Mermaid diagram to visualize the Dev Container architecture and workflow.
Details:
• Added comprehensive Mermaid diagram showing the complete Dev Container setup flow
• Visualized the relationship between IDE extensions (Remote-SSH and Dev Container)
• Illustrated volume mounts for project directory and HuggingFace cache
• Showed git config copy mechanism via Dev Container settings
• Depicted the Docker image to container relationship and ubuntu user context
Where should the reviewer start?
.devcontainer/README.md - Review the newly added Mermaid diagram at the top of the file to ensure it accurately represents the Dev Container architecture.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit