-
Notifications
You must be signed in to change notification settings - Fork 692
chore: enable rust-analyzer for all features in dev container #2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDevcontainer VS Code configuration updated to enable Rust Analyzer cargo all features by setting rust-analyzer.cargo.allFeatures=true in .devcontainer/devcontainer.json. Existing files.insertFinalNewline retained with a trailing comma adjustment. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.devcontainer/devcontainer.json (1)
37-44: Optional: guard against heavier indexing/Clippy work with all features enabled.All-features can significantly increase rust-analyzer indexing and clippy compile scope across workspace members and targets. If you see sluggishness or higher RAM/CPU in the container, consider limiting check targets while keeping IDE symbol visibility broad.
Suggested lightweight adjustment:
- Keep rust-analyzer.cargo.allFeatures=true for IDE features.
- Limit on-save checks to primary library/bin targets (skip tests/examples/benches) to avoid full rebuilds.
Apply this optional change near the existing rust-analyzer settings:
@@ "rust-analyzer.checkOnSave.command": "clippy", "rust-analyzer.checkOnSave.enable": true, @@ - "files.insertFinalNewline": true, - "rust-analyzer.cargo.allFeatures": true + "files.insertFinalNewline": true, + "rust-analyzer.cargo.allFeatures": true, + "rust-analyzer.check.allTargets": falseIf you prefer, I can also stage a variant that uses a curated feature set for specific crates instead of allFeatures, but I understand the current goal is “enable everything” for developer convenience—confirm which direction you want.
Also applies to: 45-53, 55-56
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.devcontainer/devcontainer.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (2)
.devcontainer/devcontainer.json (2)
56-56: Enabling all Cargo features in rust-analyzer meets the PR objective.Setting rust-analyzer.cargo.allFeatures to true aligns with the intent to surface symbols behind optional features (e.g., block-manager). No correctness concerns with the JSONC here.
55-55: Minor JSONC maintenance tweak looks good.files.insertFinalNewline remains true and the preceding comma placement is valid in this JSON-with-comments context.
Overview:
Useful for features like block-manager
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit