chore: Rust to 1.89 and edition 2024 #2659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamking
requested review from
a team,
alec-flowers,
ishandhanani,
nnshah1,
ptarasiewiczNV,
richardhuo-nv,
rmccorm4 and
tanmayv25
as code owners
grahamking
force-pushed
the
gk-rust-1.89
branch
from
1b26312 to
40e0e18
Compare
keivenchang
approved these changes
Aug 22, 2025
Contributor
keivenchang
left a comment
keivenchang
left a comment
There was a problem hiding this comment.
+1 Approve per conversation that this is just a Rust upgrade. Automated. Good luck.
It's a pain because it needs NIXL so I can't run it. All manual.
grahamking
force-pushed
the
gk-rust-1.89
branch
from
7b8becb to
fb66e35
Compare
alec-flowers
approved these changes
Aug 22, 2025
hhzhang16
pushed a commit
that referenced
this pull request
Aug 27, 2025
Signed-off-by: Hannah Zhang <hannahz@nvidia.com>
nv-anants
pushed a commit
that referenced
this pull request
Aug 28, 2025
jasonqinzhou
pushed a commit
that referenced
this pull request
Aug 30, 2025
Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
KrishnanPrash
pushed a commit
that referenced
this pull request
Sep 2, 2025
Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
nnshah1
pushed a commit
that referenced
this pull request
Sep 8, 2025
Signed-off-by: nnshah1 <neelays@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is time.