Skip to content

Conversation

@saturley-hall
Copy link
Member

@saturley-hall saturley-hall commented Sep 18, 2025

Overview:

On publication to crates.io the SPDX identifier of Apache 2.0 needs to be Apache-2.0

Summary by CodeRabbit

  • Chores
    • Aligned package license metadata with SPDX-compliant formatting. No changes to configuration, dependencies, or APIs.
  • Documentation
    • Updated displayed license string to standard SPDX identifiers to improve compliance tooling compatibility. No impact on runtime behavior.

Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 18, 2025

Walkthrough

Updated the license field in lib/async-openai/Cargo.toml from "Apache 2.0 AND MIT" to "Apache-2.0 AND MIT" to match SPDX formatting. No other changes.

Changes

Cohort / File(s) Summary of Changes
Manifest SPDX correction
lib/async-openai/Cargo.toml
License string adjusted to SPDX-compliant format: "Apache-2.0 AND MIT". No other manifest or code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my nose at hyphen’s grace,
Two licenses in proper place—
From space to dash, a tidy sight,
SPDX now set just right.
I thump approval, hop along,
A tiny fix, a tidy song.

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR includes a brief Overview stating the SPDX identifier correction but does not follow the repository template: the required "Details", "Where should the reviewer start?", and "Related Issues" sections are missing, so the description is incomplete for reviewers. Please expand the PR description to include a "Details" section describing the exact file change(s) and edit, a "Where should the reviewer start?" section pointing to lib/async-openai/Cargo.toml, and a "Related Issues" entry (or "None") to match the repository template.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely and accurately describes the primary change in this PR — correcting the crate SPDX identifier to "Apache-2.0" — and directly matches the change to lib/async-openai/Cargo.toml described in the summary.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
lib/async-openai/Cargo.toml (1)

2-10: Minor: keep license prose consistent with SPDX.

Header line "Licensed under Apache 2.0" (Line 9) is non‑SPDX prose while Line 2 already uses the SPDX tag. For consistency, either change the prose to “Apache‑2.0” or drop it in favor of the SPDX tag.

Apply:

-# Licensed under Apache 2.0
+# Licensed under Apache-2.0
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9cb942 and 2c7dfaa.

📒 Files selected for processing (1)
  • lib/async-openai/Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build and Test - vllm
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (2)
lib/async-openai/Cargo.toml (2)

14-14: SPDX identifier fix is correct; confirm AND vs OR intent.

"Apache-2.0 AND MIT" is a valid SPDX expression and fixes the crates.io formatting issue. Please confirm that the crate is intentionally dual-licensed cumulatively (AND) rather than permissively (OR), which is the common pattern in Rust crates.

If the intent is user choice, apply:

-license = "Apache-2.0 AND MIT"
+license = "Apache-2.0 OR MIT"

11-21: Verify LICENSE and ATTRIBUTIONS are included in the published dynamo-async-openai crate

Detected files: ATTRIBUTIONS-Rust.md and LICENSE at repo root; no include/exclude entries were found in lib/async-openai/Cargo.toml, so packaging can’t be confirmed. Run locally:
cargo package --list -p dynamo-async-openai --no-verify
and confirm ATTRIBUTIONS-Rust.md and LICENSE appear. If they’re missing, add them to lib/async-openai/Cargo.toml under package.include or copy them into that crate’s directory so they are packaged.

@saturley-hall saturley-hall merged commit dcf55c3 into main Sep 18, 2025
10 of 11 checks passed
@saturley-hall saturley-hall deleted the harrison/fix-dynamo-async-openai-spdx branch September 18, 2025 20:19
saturley-hall added a commit that referenced this pull request Sep 18, 2025
Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
saturley-hall added a commit that referenced this pull request Sep 18, 2025
Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants