-
Notifications
You must be signed in to change notification settings - Fork 690
fix: incorrect crate SPDX identifier, Apache-2.0 #3118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
WalkthroughUpdated the license field in lib/async-openai/Cargo.toml from "Apache 2.0 AND MIT" to "Apache-2.0 AND MIT" to match SPDX formatting. No other changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
lib/async-openai/Cargo.toml (1)
2-10: Minor: keep license prose consistent with SPDX.Header line "Licensed under Apache 2.0" (Line 9) is non‑SPDX prose while Line 2 already uses the SPDX tag. For consistency, either change the prose to “Apache‑2.0” or drop it in favor of the SPDX tag.
Apply:
-# Licensed under Apache 2.0 +# Licensed under Apache-2.0
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
lib/async-openai/Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build and Test - vllm
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (2)
lib/async-openai/Cargo.toml (2)
14-14: SPDX identifier fix is correct; confirm AND vs OR intent."Apache-2.0 AND MIT" is a valid SPDX expression and fixes the crates.io formatting issue. Please confirm that the crate is intentionally dual-licensed cumulatively (AND) rather than permissively (OR), which is the common pattern in Rust crates.
If the intent is user choice, apply:
-license = "Apache-2.0 AND MIT" +license = "Apache-2.0 OR MIT"
11-21: Verify LICENSE and ATTRIBUTIONS are included in the published dynamo-async-openai crateDetected files: ATTRIBUTIONS-Rust.md and LICENSE at repo root; no include/exclude entries were found in lib/async-openai/Cargo.toml, so packaging can’t be confirmed. Run locally:
cargo package --list -p dynamo-async-openai --no-verify
and confirm ATTRIBUTIONS-Rust.md and LICENSE appear. If they’re missing, add them to lib/async-openai/Cargo.toml under package.include or copy them into that crate’s directory so they are packaged.
Signed-off-by: Harrison Saturley-Hall <hsaturleyhal@nvidia.com>
Overview:
On publication to crates.io the SPDX identifier of
Apache 2.0needs to beApache-2.0Summary by CodeRabbit