-
Notifications
You must be signed in to change notification settings - Fork 688
feat: install dynamo operator cluster-wide by default #3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates Helm chart default to disable namespaceRestriction for the Dynamo Operator (cluster-wide by default), expands README guidance on scoping/targetNamespace, and standardizes Kubernetes docs to use the dynamo-system namespace with added notes on operator scope and setup commands. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant H as Helm Chart
participant O as Dynamo Operator
participant NS as Kubernetes Namespaces
U->>H: helm install ... (namespaceRestriction.enabled=false)
H-->>O: Deploy Operator (cluster-scoped RBAC)
O->>NS: Watch all namespaces
alt Restrict to a namespace
U->>H: helm install ... --set dynamo-operator.namespaceRestriction.enabled=true --set dynamo-operator.namespaceRestriction.targetNamespace=<ns>
H-->>O: Deploy Operator (namespaced RBAC)
O->>NS: Watch only <ns> (defaults to release namespace if unset)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (1)
deploy/cloud/helm/platform/values.yaml (1)
36-38: Clarify description of targetNamespace (watch scope vs deploy ns).
Wording “Target namespace for operator deployment” can be read as where the operator Pod runs, not what it watches. Suggest clarifying it as the namespace the operator watches when restriction is enabled.Apply this diff for clarity:
- # -- Target namespace for operator deployment (leave empty for current namespace) + # -- Target namespace to watch when restriction is enabled (defaults to Helm release namespace if empty)
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
deploy/cloud/helm/platform/README.md(1 hunks)deploy/cloud/helm/platform/values.yaml(1 hunks)docs/kubernetes/README.md(2 hunks)docs/kubernetes/installation_guide.md(3 hunks)docs/kubernetes/logging.md(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: julienmancuso
PR: ai-dynamo/dynamo#1474
File: deploy/cloud/operator/internal/controller/dynamocomponent_controller.go:1308-1312
Timestamp: 2025-06-11T21:29:28.650Z
Learning: User julienmancuso expects replies in English; avoid switching languages unless explicitly requested.
📚 Learning: 2025-09-17T22:35:40.674Z
Learnt from: julienmancuso
PR: ai-dynamo/dynamo#3100
File: deploy/cloud/operator/cmd/main.go:186-190
Timestamp: 2025-09-17T22:35:40.674Z
Learning: The mpiRunSecretName validation in deploy/cloud/operator/cmd/main.go is safe for upgrades because the Helm chart automatically populates dynamo-operator.dynamo.mpiRun.secretName with a default value of "mpi-run-ssh-secret" and includes SSH key generation functionality via sshKeygen.enabled: true.
Applied to files:
deploy/cloud/helm/platform/values.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (5)
docs/kubernetes/logging.md (1)
34-34: LGTM: Namespace example aligned to dynamo-system.
Matches the new defaults across docs. No further action.docs/kubernetes/installation_guide.md (2)
72-72: LGTM: Default namespace set to dynamo-system.
Consistent with the broader docs shift.
102-110: Good tip block; commands are correct.
Minor note:targetNamespaceis ignored unless restriction is enabled, which you state. No changes needed.If desired, add a one-liner example combining both flags:
--set "dynamo-operator.namespaceRestriction.enabled=true,dynamo-operator.namespaceRestriction.targetNamespace=dynamo-namespace"docs/kubernetes/README.md (1)
26-26: LGTM: Default namespace set to dynamo-system.
Matches installation guide.deploy/cloud/helm/platform/README.md (1)
61-63: LGTM: Docs reflect new default (cluster-wide).
Table defaults and descriptions match values.yaml.Consider adding a short “Upgrade Notes” section calling out the default change to cluster-wide and how to retain prior behavior via
namespaceRestriction.enabled=true.
Signed-off-by: Julien Mancuso <jmancuso@nvidia.com>
cbb8db0 to
96d4459
Compare
Signed-off-by: Julien Mancuso <jmancuso@nvidia.com>
tmonty12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
Signed-off-by: Julien Mancuso <jmancuso@nvidia.com> Signed-off-by: Kyle H <kylhuang@nvidia.com>
Overview:
install dynamo operator cluster-wide by default
Summary by CodeRabbit
Chores
Documentation