fix: TENSORRTLLM_PIP_WHEEL_DIR has reasonable default set when building and installing TRTLLM from source

[nv-kmcgill53]

Overview:

This fixes a bug in build.sh where, when building TRTLLM from source for installation in the container, the TENSORRTLLM_PIP_WHEEL_DIR was not set to a default when omitted as a flag on the command line. This caused a build failure after the trtllm wheel is built when a null directory was trying to be constructed.

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• closes DIS-1053

Summary by CodeRabbit

• Chores
  • Improved build process reliability by ensuring the wheel output directory is properly initialized with a default value and displayed during the build process for better transparency.

[coderabbitai]

Walkthrough

The build script now defaults the TENSORRTLLM_PIP_WHEEL_DIR variable to a predetermined value when not explicitly provided and adds an echo statement to display the resolved output directory path during execution.

Changes

Cohort / File(s)	Summary
Variable Default and Output Directory Display container/build.sh	Added default assignment for TENSORRTLLM_PIP_WHEEL_DIR using parameter expansion and diagnostic echo statement to print the resolved directory path

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰✨ A wheel path now clear, with defaults so dear,
No mystery, just echoes to hear!
Two lines, one goal—let builders see true,
The output directory, polished and new! 🛠️

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description covers the overview of the bug fix and references a related issue, though the Details and Where should the reviewer start sections are empty.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately describes the main change: setting a reasonable default for TENSORRTLLM_PIP_WHEEL_DIR when building TRTLLM from source, which directly addresses the bug fix implemented in the PR.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adbe133 and e1c0d57.

📒 Files selected for processing (1)

• container/build.sh (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: nnshah1
Repo: ai-dynamo/dynamo PR: 2489
File: container/deps/vllm/install_vllm.sh:151-152
Timestamp: 2025-08-18T16:52:15.659Z
Learning: The VLLM_PRECOMPILED_WHEEL_LOCATION environment variable, when exported, automatically triggers vLLM's build system to use the precompiled wheel instead of building from source, even when using standard `uv pip install .` commands in container/deps/vllm/install_vllm.sh.

Learnt from: nnshah1
Repo: ai-dynamo/dynamo PR: 2489
File: container/deps/vllm/install_vllm.sh:151-152
Timestamp: 2025-08-18T16:52:15.659Z
Learning: The VLLM_PRECOMPILED_WHEEL_LOCATION environment variable is an official vLLM environment variable that, when exported, automatically triggers vLLM's build system to use the specified precompiled wheel instead of building from source. This works even with standard `uv pip install .` commands without requiring explicit reference to the variable in the install command. The vLLM build system internally detects and uses this environment variable.

📚 Learning: 2025-08-18T16:52:15.659Z

Learnt from: nnshah1
Repo: ai-dynamo/dynamo PR: 2489
File: container/deps/vllm/install_vllm.sh:151-152
Timestamp: 2025-08-18T16:52:15.659Z
Learning: The VLLM_PRECOMPILED_WHEEL_LOCATION environment variable, when exported, automatically triggers vLLM's build system to use the precompiled wheel instead of building from source, even when using standard `uv pip install .` commands in container/deps/vllm/install_vllm.sh.

Applied to files:

• container/build.sh

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: operator (arm64)
• GitHub Check: operator (amd64)
• GitHub Check: trtllm (arm64)
• GitHub Check: sglang (arm64)
• GitHub Check: sglang (amd64)
• GitHub Check: vllm (arm64)
• GitHub Check: vllm (amd64)
• GitHub Check: trtllm (amd64)
• GitHub Check: Build and Test - dynamo

🔇 Additional comments (1)

container/build.sh (1)

752-766: Verify the build context path and wheel discovery logic after applying the default.

Once DEFAULT_TENSORRTLLM_PIP_WHEEL_DIR is properly defined, ensure that the build script correctly discovers the wheel file at line 765 using find $TENSORRTLLM_PIP_WHEEL_DIR. Confirm that the default directory is both writable and that subsequent build steps handle the case where the directory exists but is empty.

[zhongdaor-nv]

this assert is always true, are we just want to print log message here?

[nv-kmcgill53]

You are right, this was a copy paste error