feat: add group-writable permissions to Dockerfiles for faster builds #4578
+276
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement umask 002 wrapper and COPY --chmod=775 patterns across all Dockerfiles (vllm, sglang, trtllm) to ensure group-writable permissions. This allows both dynamo user (UID 1000) and Dev Container users (UID != 1000) to work without slow chown -R operations, saving 2-10 minutes per framework! Key changes: - Add umask wrapper script to create group-writable files by default - Use COPY --chmod=775 + chmod g+w pattern for directories - Apply to workspace, home, venv, and cargo/rustup directories - Update build.sh to support --runtime-image and --no-latest flags - Add framework-specific base image tags to prevent parallel build conflicts Resolves issues where non-dynamo users couldn't write to workspace/venv. Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com> Rename --no-latest flag to --no-tag-latest in build.sh Signed-off-by: Keiven Chang <keivenchang@users.noreply.github.com>
keivenchang
force-pushed
the
keivenchang/ops-2193__update-dockerfile-group-permissions-for-development
branch
from
02fb0c7 to
3df4abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Adds group-writable permissions to Dockerfiles using umask 002 wrapper and COPY --chmod=775 patterns. Enables Dev Container users (UID != 1000) to work without slow chown -R operations, saving 2-10 minutes per build.
Details:
COPY --chmod=775 + chmod g+wpattern for workspace, home, venv, cargo/rustup directoriesWhere should the reviewer start?
Header comments in container/Dockerfile.vllm (lines 4-22) explain the permissions strategy and COPY --chmod pattern.
Related Issues:
Relates to OPS-2193
/coderabbit profile chill