-
Notifications
You must be signed in to change notification settings - Fork 709
fix: update GAIE recipe to reflect frontend image release #4594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation updates to two README files informing users that the frontend Dynamo image will not be included in the 0.7.0 release. Changes optional guidance to mandatory instructions for building a custom EPP image, with added prominent warnings and standardized phrasing throughout. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~4 minutes
Poem
Pre-merge checks✅ Passed checks (3 passed)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
deploy/inference-gateway/README.md (1)
114-115: Standardize warning phrasing across the file.The file contains two warnings about the 0.7.0 release (lines 114 and 150) with inconsistent formatting and terminology:
- Line 114 uses
⚠️ Note:(unbolded) and references "Build the custom EPP image" section- Line 150 uses
**⚠️ Important:**(bolded) and refers to "steps below"Since the PR objectives emphasize standardized phrasing throughout the documentation, consider aligning these warnings to use the same prefix style, emphasis level, and terminology. Additionally, clarify whether both warnings are necessary or if one can be consolidated.
Also applies to: 150-154
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
deploy/inference-gateway/README.md(2 hunks)recipes/README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: operator (amd64)
- GitHub Check: trtllm (amd64)
- GitHub Check: vllm (arm64)
- GitHub Check: vllm (amd64)
- GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
recipes/README.md (1)
189-191: Verify the anchor link to the build instructions section.The reference to
#1-build-the-custom-epp-imageshould be verified to ensure it matches the markdown heading created by the "##### 1. Build the custom EPP image #####" section indeploy/inference-gateway/README.md. Most markdown renderers generate anchors by converting to lowercase and replacing spaces with hyphens, but this depends on the specific renderer used.
Overview:
The Dynamo frontend image will not be released in 0.7.0. This PR updates documentation to reflect that and point towards instructions for building Dynamo EPP image.
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.