-
Notifications
You must be signed in to change notification settings - Fork 181
Fix rust build with stubs #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but we definitely need some CI test for the stub api
|
I think it can be a great idea to add cargo build --features stub-apiI think it can be added in this PR, it's just a single line of change |
+1 |
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com>
Added |
|
@roiedanino can this be merged? |
In-between #477 and now, some refactor dropped the actual binding generation when using stubs, leading to an error
This PR fixes that.