DEVICE/API: Simplify createGpuXferReq to single-step API - WIP #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi michal-shalev! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Signed-off-by: Michal Shalev <mshalev@nvidia.com>
michal-shalev
force-pushed
the
nixl-single-step-gpu-xfer-creation
branch
from
58ce4b6 to
d5060d0
Compare
michal-shalev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Replace two-step GPU transfer request creation with a single
createGpuXferReqAPI that takes descriptor lists directly and returns both transfer request and GPU request handles.Why?
Simplify the API by reducing GPU transfer request creation from two separate function calls to a single call.
How?
Updated
createGpuXferReqto substitute calls tocreateXferReq+createGpuXferReq. Removed the oldcreateGpuXferReqmethod and updated tests accordingly.