adding user defined callback to peer metadata removal from etcd #933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi RoeyAzran1992! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Giving the user the option to define a callback for the peer's metadata removal from the ETCD.
Why?
Current implementation has a race in resource release flow: When a peer removes its metadata from the ETCD, NIXL automatically invalidates cached MD, but the upper layers are not aware of this invalidation and will try to release requests to connections that were already invalidated.
How?
Allowing the user to install a customized callback so he can decide what actions to do upon peer metadata removal from ETCD (releasing transfer requests, invalidating the cached MD, etc.).