-
Notifications
You must be signed in to change notification settings - Fork 187
Plugin manager: use info instead of error for plugins missing external deps #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l dependencies Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
|
👋 Hi ovidiusm! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
Contributor
Author
|
/build |
brminich
approved these changes
Oct 29, 2025
Contributor
|
/build |
ovidiusm
added a commit
to ovidiusm/nixl
that referenced
this pull request
Oct 29, 2025
…l dependencies (ai-dynamo#964) Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
e-ago
pushed a commit
to e-ago/nixl-doca-31
that referenced
this pull request
Nov 12, 2025
…l dependencies (ai-dynamo#964) Signed-off-by: Ovidiu Mara <ovidium@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Python wheel does not bundle libfabric dependencies. As a result, we get log errors on non-AWS systems:
These logs should be INFO.