Skip to content

make nixlbench exit with failure when iov consistency check fails. #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

make nixlbench exit with failure when iov consistency check fails. #992

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4dd620
make nixlbench exit with failure when iov consistency check fails.
fengjica Nov 3, 2025
02b61fb
Merge branch 'main' into bugfix
aranadive Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions benchmark/nixlbench/src/utils/utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,6 +659,7 @@ void xferBenchUtils::checkConsistency(std::vector<std::vector<xferBenchIOV>> &io
xferBenchConfig::num_initiator_dev);
gusli_devmap_init = true;
}
bool pass_check_consistency = true;
for (const auto &iov_list: iov_lists) {
for(const auto &iov: iov_list) {
void *addr = NULL;
Expand Down Expand Up @@ -793,6 +794,7 @@ void xferBenchUtils::checkConsistency(std::vector<std::vector<xferBenchIOV>> &io
rc = allBytesAre(addr, len, check_val);
if (true != rc) {
std::cerr << "Consistency check failed for iov " << i << ":" << j << std::endl;
pass_check_consistency = false;
}
// Free the addr only if is allocated here
if (is_allocated) {
Expand All @@ -802,6 +804,10 @@ void xferBenchUtils::checkConsistency(std::vector<std::vector<xferBenchIOV>> &io
}
i++;
}
if (!pass_check_consistency) {
std::cerr << "Consistency check failed" << std::endl;
exit(EXIT_FAILURE);
}
}

void
Expand Down