Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation in Bahasa Indonesia #326

Merged
merged 3 commits into from
Dec 30, 2021

Conversation

lauslim12
Copy link
Contributor

@lauslim12 lauslim12 commented Dec 30, 2021

Hi!

Thanks for making this library. It's super simple, fast, and very useful for my use-cases!

If you don't mind, I have translated and added README.id-ID.md for internationalization purposes (I'm from Indonesia). The documentation now has four languages: English, Russian, Chinese, and Bahasa Indonesia 🎉

By the way, I have a question about a single statement in async part of the documentation:

Unfortunately, you will lose Web Crypto API advantages in a browser if you use the asynchronous API. So, currently, in the browser, you are limited with either security or asynchronous behavior.

The 'security' part here is a bit confusing for me. So, in order to remove any ambiguity, I think it's better if we rewrite this to be like:

Unfortunately, you will lose Web Crypto API advantages in a browser if you use the asynchronous API. So, currently, in the browser, you are limited with either security (using nanoid), asynchronous behavior (using nanoid/async), or non-secure behavior (using nanoid/non-secure) that will be explained in the next part of the documentation.

I have not yet edited it, but what do you think about this rewrite?

Hopefully, my PR is useful. Thanks again!

@ai
Copy link
Owner

ai commented Dec 30, 2021

I like that language code id is relavant to the lib :D

@ai
Copy link
Owner

ai commented Dec 30, 2021

I have not yet edited it, but what do you think about this rewrite?

I like the suggestion, please add commit to this PR

@lauslim12
Copy link
Contributor Author

I like that language code id is relavant to the lib :D

:D

I like the suggestion, please add commit to this PR

Added 🥳

@ai ai merged commit 9661320 into ai:main Dec 30, 2021
@ai
Copy link
Owner

ai commented Dec 30, 2021

Thanks!

@lauslim12 lauslim12 deleted the indonesian-documentation branch December 30, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants