fix(node): use webcrypto export from node:crypto
#448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. The fix was released in 5.0.2. |
brc-dd
added a commit
to vuejs/vitepress
that referenced
this pull request
Oct 15, 2023
bumping nanoid again to v5 -- issue regarding crypto.getRandomValues is resolved upstream -- ai/nanoid#448
jasonreyes9
added a commit
to jasonreyes9/vitepress-vuejs
that referenced
this pull request
Oct 31, 2023
bumping nanoid again to v5 -- issue regarding crypto.getRandomValues is resolved upstream -- ai/nanoid#448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
crypto.webcrypto.getRandomValues()is recommended instead of directly using the aliased version fromcrypto.getRandomValues()as the latter is not meant to be compatible with the WebCrypto spec and is non-standard.There was earlier discussion on this in the node repo - nodejs/node#41779, nodejs/node#41782, nodejs/node#41760
This is breaking some downstream tools as well that are bundling / down-compiling nanoid (although that's not much of an nanoid issue).
PS: updating the
cleanscript as well. Runningtestwas failing for new contributors who don't already have a coverage directory.