Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jiti usage to support Top-Level await syntax #378

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Update jiti usage to support Top-Level await syntax #378

merged 2 commits into from
Jan 8, 2025

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Updates jiti usage to support Top-Level await syntax within config files.

@ai ai merged commit 6a492c7 into ai:main Jan 8, 2025
3 checks passed
@aryaemami59 aryaemami59 deleted the fix/top-level-await branch January 8, 2025 10:52
@aryaemami59
Copy link
Contributor Author

@ai Is it possible to get a new release with these changes included?

@ai
Copy link
Owner

ai commented Jan 8, 2025

Sure. I just blocked by strange issue with Vitest update, but maybe I can just ignore it.

@aryaemami59
Copy link
Contributor Author

@ai

Sure. I just blocked by strange issue with Vitest update, but maybe I can just ignore it.

What's the issue? Maybe I can help!

@ai
Copy link
Owner

ai commented Jan 8, 2025

After vitest update I start to have difference between snapshot locally and in the CI. Can you try to update vitest and @vitest/coverage-v8?

@aryaemami59
Copy link
Contributor Author

aryaemami59 commented Jan 8, 2025 •
edited
Loading

After vitest update I start to have difference between snapshot locally and in the CI. Can you try to update vitest and @vitest/coverage-v8?

I've dealt with that problem before, let me see if I can fix it.

Can I see the snapshot mismatch you're getting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryaemami59 @ai