-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Webpack to v4. #42
Conversation
- Updated Webpack dependency to v4.0.0-beta.2. - Updated Webpack related dependencies for the Yarn lock file. - In the changelog fixed capitalization of “Webpack” everywhere and ran Prettier.
Tested it using The warning is harmless, some packages are waiting for a stable v4 before adopting the new API and Webpack will still support the old for a while. I looked into all the Webpack related dependencies and I could not find anything that would break moving to v4. |
@jaydenseric do you have this warning without |
Yes. |
Could you please revert ChangeLog changes? ;) If you want to change format, it should be in the different PR. |
The changelog formatting matches the same way you have the readme formatted; new lines under headings. |
|
Seems like you also need to fix tests, Webpack 4 changes sizes and |
Feel free to add commits to get this PR across the line, I don't have this project open anymore and am too busy ATM to work out the tests and things to see it through 🙂 |
@jaydenseric don’t worry. I will finish it over the weekend. Can I only ask you to revert ChangeLog changes, because if I accept this PR (to fix tests), git history will be tricky? |
I created issue about depreacted warning: webpack-contrib/webpack-bundle-analyzer#154 Also I should think on weekends about using Webpack’s |
I made a PR to Webpack Bundle Analyzer. Since warning is showing in any Size Limit mode, I need to wait for this PR (or Size Limit tests will fail). |
PR to |
PR to |
All PRs were accepted. I manually took changes from this commit aca11bf |
Released in 0.15. |
Fixes #41: