Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusting test setup and adding a basic test #172

Merged
merged 6 commits into from
Nov 3, 2024
Merged

Conversation

sirkitree
Copy link
Collaborator

Relates to:

#64

Risks

Low

Background

What does this PR do?

This modifies the test runner setup for jest to be cross platform and then adds a very basic test that can be run with pnpm test. We'll want to add further testing, but this gets us to a basic working state.

What kind of change is this?

Updates (new versions of included code)

Documentation changes needed?

Testing

Detailed testing steps

  1. pnpm install
  2. pnpm test

You should see output similar to:
image

@sirkitree
Copy link
Collaborator Author

ci was failing so the last few commits here do the following:

There are two main types of issues in the build:

  1. Missing file extensions in imports (due to NodeNext module resolution)
  2. Type errors with BigNumber and some other dependencies
  • First, modify the tsconfig.json to handle the module resolution differently
  • Update the CI workflow to include testing
  • Update any files using BigNumber to use the new utility file
  • For the PDF.js issue, add the types
  • For the youtube-dl-exec issue, update how it's imported and used.
  • Update video.ts to use this wrapper instead of the direct import

@sirkitree sirkitree linked an issue Nov 3, 2024 that may be closed by this pull request
@sirkitree sirkitree removed a link to an issue Nov 3, 2024
@lalalune lalalune merged commit b00d1ea into main Nov 3, 2024
1 check passed
@lalalune lalalune deleted the 64__basic-tests branch November 3, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants