Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Nonautoregressive Methods #122

Merged
merged 11 commits into from
Mar 8, 2024
Merged

[Feat] Nonautoregressive Methods #122

merged 11 commits into from
Mar 8, 2024

Conversation

cbhua
Copy link
Member

@cbhua cbhua commented Mar 1, 2024

Description

Contributed by @Furffico, @tycbony, and @henry-yeh from DeepACO and GLOP. Adding new support for non-autoregressive (NAR) methods, including edge embedding methods for various environments, anisotropic GNN encoder with edge-gating mechanism, non-autoregressive decoder, and related utils functions.

Motivation and Context

NAR methods are an important extension for RL4CO model support, aside from various previous autoregressive methods.

Types of changes

  • New feature (mostly just adding new functionality)
  • Example (update in the folder of examples)
  • Breaking change (there are some changes to basic classes, even though most of them are simple code-level optimization, just be careful about hidden bugs)

Checklist

  • This change requires an extension of the documentation.
  • This change has provided a testing.

Copy link
Member Author

@cbhua cbhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code, nice work.

rl4co/models/nn/env_embeddings/edge.py Show resolved Hide resolved
rl4co/models/nn/env_embeddings/edge.py Show resolved Hide resolved
rl4co/models/zoo/common/nonautoregressive/decoder.py Outdated Show resolved Hide resolved
rl4co/models/zoo/common/nonautoregressive/encoder.py Outdated Show resolved Hide resolved
rl4co/models/zoo/common/nonautoregressive/encoder.py Outdated Show resolved Hide resolved
rl4co/utils/ops.py Outdated Show resolved Hide resolved
rl4co/models/nn/graph/gcn.py Outdated Show resolved Hide resolved
@cbhua cbhua requested a review from fedebotu March 4, 2024 04:47
@fedebotu fedebotu changed the title [Feat] Nonautoregressive Methods Supporting [Feat] Nonautoregressive Methods Mar 4, 2024
@Furffico
Copy link
Member

Furffico commented Mar 5, 2024

I have modified the code following the review above. Please review the changes.

Copy link
Member Author

@cbhua cbhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

cbhua added a commit that referenced this pull request Mar 8, 2024
…122

[Feat] Nonautoregressive Methods Resolve Conflicts from #122
@cbhua cbhua merged commit 716de24 into ai4co:main Mar 8, 2024
@Furffico Furffico deleted the nar branch March 9, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants