feat: create ros2-ws image that has ros2-control installed #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domire8
commented
May 2, 2024
domire8
commented
May 2, 2024
|
The labels seem to be here. Also, I packaged a backend with this base image and there seem to be no problems 👍 |
eeberhard
approved these changes
May 2, 2024
There was a problem hiding this comment.
so just to clarify, the point is to re-tag the existing (and at this point unchanging) ros2-control image as ros2-ws with the addition of the metadata labels. Then afterwards, we can revert ros2-ws Dockerfile to fully build the base workspace and install ros2-control deps all in one. And we are doing that because rebuilding ros2-ws from scratch now pulls updated (and breaking) changes to ros2 iron itself.
domire8
added a commit
that referenced
this pull request
May 2, 2024
eeberhard
added a commit
that referenced
this pull request
May 10, 2024
)" This reverts commit a284a2d.
eeberhard
added a commit
that referenced
this pull request
May 13, 2024
…s:iron (#109) * Revert "feat: create ros2-ws image that has ros2-control installed (#107)" This reverts commit a284a2d. * Revert "Revert "refactor: merge ros2-control image into ros2-ws (#100)"" This reverts commit be10502. * Revert "Revert "feat: add metadata through LABELs (#103)"" This reverts commit 5cea82c. * Revert "Revert "fix: correct user (#105)"" This reverts commit 52d2b8a. * fix: AICA image metadata base version as git tag, not ROS distro * Change tech.aica.image.metadata base.version to use VERSION (expected as semver vX.Y.Z-foo) instead of BASE_TAG (which was equiavlent to ROS distro (i.e iron). Otherwise, package-builder:v1 will fail to parse the metadata since it expects the base version as a semver string * feat: use specific SH256 digest for iron base image (2023.09.02) * Include more build args in Dockerfile to disambiguate ROS_DISTRO from BASE_TAG and to support different BASE_IMAGE * Update build push workflow to set new build args with condition based on ROS distro * Use specific SHA256 digest image and tag for ros:iron base image based on a build from September 02, 2023 * feat: add devcontainer metadata * Set default container user metadata for devcontainers (https://containers.dev/implementors/reference/#labels)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR also targets the refactor branch, but will be squashed. This is now the Dockerfile that builds on top of the ros2-control image by just adding labels.
Review guidelines
Estimated Time of Review: 4 minutes
Checklist before merging: