chore: remove unnecessary tests (#63)

aica-technology · Nov 7, 2023 · 10118e2 · 10118e2
1 parent b8d22b2
commit 10118e2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 27 deletions.
diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml
@@ -69,9 +69,8 @@ jobs:
       matrix:
         arch: [amd64, arm64]
         include:
-          # FIXME (#33): high memory usage during build
           - image: ubuntu-latest
-          - image: buildjet-8vcpu-ubuntu-2204-arm
+          - image: buildjet-4vcpu-ubuntu-2204-arm
             arch: arm64
 
     runs-on: ${{ matrix.image }}

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,7 @@ Release Versions:
 
 ## Upcoming changes (in development)
 
+- chore: remove unnecessary tests (#63)
 - Remove callback group for topics and services (#61)
 - Avoid conflict with get_parameter (#42)
 - Revise ComponentInterface by moving implementations to source file (#39)

diff --git a/source/modulo_components/test/cpp/test_component_interface.cpp b/source/modulo_components/test/cpp/test_component_interface.cpp
@@ -43,31 +43,6 @@ class ComponentInterfaceTest : public ::testing::Test {
 using NodeTypes = ::testing::Types<rclcpp::Node, rclcpp_lifecycle::LifecycleNode>;
 TYPED_TEST_SUITE(ComponentInterfaceTest, NodeTypes);
 
-// TODO this needs to be tested on component level now
-// TYPED_TEST(ComponentInterfaceTest, RatePeriodParameters) {
-//   std::shared_ptr<ComponentInterfacePublicInterface> component;
-//   auto node_options = rclcpp::NodeOptions();
-//   component = make_component_interface<TypeParam>(node_options);
-//   EXPECT_EQ(component->template get_parameter_value<int>("rate"), 10);
-//   EXPECT_EQ(component->template get_parameter_value<double>("period"), 0.1);
-
-//   node_options = rclcpp::NodeOptions().parameter_overrides({rclcpp::Parameter("rate", 200)});
-//   component = make_component_interface<TypeParam>(node_options);
-//   EXPECT_EQ(component->template get_parameter_value<int>("rate"), 200);
-//   EXPECT_EQ(component->template get_parameter_value<double>("period"), 0.005);
-
-//   node_options = rclcpp::NodeOptions().parameter_overrides({rclcpp::Parameter("period", 0.01)});
-//   component = make_component_interface<TypeParam>(node_options);
-//   EXPECT_EQ(component->template get_parameter_value<int>("rate"), 100);
-//   EXPECT_EQ(component->template get_parameter_value<double>("period"), 0.01);
-
-//   node_options =
-//       rclcpp::NodeOptions().parameter_overrides({rclcpp::Parameter("rate", 200), rclcpp::Parameter("period", 0.01)});
-//   component = make_component_interface<TypeParam>(node_options);
-//   EXPECT_EQ(component->template get_parameter_value<int>("rate"), 200);
-//   EXPECT_EQ(component->template get_parameter_value<double>("period"), 0.005);
-// }
-
 TYPED_TEST(ComponentInterfaceTest, AddBoolPredicate) {
   this->component_->add_predicate("foo", true);
   auto predicate_iterator = this->component_->predicates_.find("foo");