fix(modulo-controllers): typo in controller descriptions #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeberhard
reviewed
Oct 20, 2024
There was a problem hiding this comment.
The fix is good with me!
But preferably, we make changes and releases separately in separate PRs, so a fix: PR followed by a release: PR. This allows us to schedule releases more independently (for example if #159 should be part of the same patch)
As a side note and backlog item, we should consider a CI action that validates the descriptions against the JSON schema, and do that here as well as in the component SDK to avoid such issues in future.
bpapaspyros
force-pushed
the
fix/input_validity_period
branch
from
330208e
to
7ea0091
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue by removing the underscore in the corresponding description file.
Review guidelines
Estimated Time of Review: 1 minutes
Checklist before merging: