Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary tests #63

Merged
merged 3 commits into from
Nov 7, 2023
Merged

chore: remove unnecessary tests #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2601e04
chore: remove unecessary tests
domire8 Nov 7, 2023
dfb0366
build: try cheaper runner
domire8 Nov 7, 2023
68ab0ac
docs: update changelog
domire8 Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/build-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ jobs:
matrix:
arch: [amd64, arm64]
include:
# FIXME (#33): high memory usage during build
- image: ubuntu-latest
- image: buildjet-8vcpu-ubuntu-2204-arm
- image: buildjet-4vcpu-ubuntu-2204-arm
domire8 marked this conversation as resolved.
Show resolved Hide resolved
arch: arm64

runs-on: ${{ matrix.image }}
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ Release Versions:

## Upcoming changes (in development)

- chore: remove unnecessary tests (#63)
- Remove callback group for topics and services (#61)
- Avoid conflict with get_parameter (#42)
- Revise ComponentInterface by moving implementations to source file (#39)
Expand Down
25 changes: 0 additions & 25 deletions source/modulo_components/test/cpp/test_component_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,31 +43,6 @@ class ComponentInterfaceTest : public ::testing::Test {
using NodeTypes = ::testing::Types<rclcpp::Node, rclcpp_lifecycle::LifecycleNode>;
TYPED_TEST_SUITE(ComponentInterfaceTest, NodeTypes);

// TODO this needs to be tested on component level now
// TYPED_TEST(ComponentInterfaceTest, RatePeriodParameters) {
// std::shared_ptr<ComponentInterfacePublicInterface> component;
// auto node_options = rclcpp::NodeOptions();
// component = make_component_interface<TypeParam>(node_options);
// EXPECT_EQ(component->template get_parameter_value<int>("rate"), 10);
// EXPECT_EQ(component->template get_parameter_value<double>("period"), 0.1);

// node_options = rclcpp::NodeOptions().parameter_overrides({rclcpp::Parameter("rate", 200)});
// component = make_component_interface<TypeParam>(node_options);
// EXPECT_EQ(component->template get_parameter_value<int>("rate"), 200);
// EXPECT_EQ(component->template get_parameter_value<double>("period"), 0.005);

// node_options = rclcpp::NodeOptions().parameter_overrides({rclcpp::Parameter("period", 0.01)});
// component = make_component_interface<TypeParam>(node_options);
// EXPECT_EQ(component->template get_parameter_value<int>("rate"), 100);
// EXPECT_EQ(component->template get_parameter_value<double>("period"), 0.01);

// node_options =
// rclcpp::NodeOptions().parameter_overrides({rclcpp::Parameter("rate", 200), rclcpp::Parameter("period", 0.01)});
// component = make_component_interface<TypeParam>(node_options);
// EXPECT_EQ(component->template get_parameter_value<int>("rate"), 200);
// EXPECT_EQ(component->template get_parameter_value<double>("period"), 0.005);
// }

TYPED_TEST(ComponentInterfaceTest, AddBoolPredicate) {
this->component_->add_predicate("foo", true);
auto predicate_iterator = this->component_->predicates_.find("foo");
Expand Down