Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller-interface): add set_parameter_value #93

Merged
merged 6 commits into from
May 17, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented May 13, 2024

Description

I'm working on harmonizing the provided interface between the component and controller classes. Hence the addition of set_parameter_value. Additionally I changed two things under the hood:

  1. The validation of the base class parameters should not be the responsibility of the derived class. That's why - as in the component interface - the on_validate_parameter_callback is wrapped in an additional validate_parameter method
  2. Two functions were inlined for no reason, I moved them to the source file.

Review guidelines

Estimated Time of Review: 7 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 merged commit 88dbcd1 into feat/mc-interface May 17, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
@domire8 domire8 deleted the feat/set-parameter branch May 17, 2024 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants