Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly call on_deactivate wrapper #96

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: correctly call on_deactivate wrapper #96

merged 2 commits into from
May 17, 2024

Conversation

domire8
Copy link
Member

@domire8 domire8 commented May 15, 2024

Description

Small bug that was found today

Review guidelines

Estimated Time of Review: 3 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8
Copy link
Member Author

domire8 commented May 15, 2024

Porting this from https://github.com/aica-technology/modulo-controllers/pull/213

@domire8 domire8 merged commit 05f51a8 into feat/mc-interface May 17, 2024
4 checks passed
@domire8 domire8 deleted the fix/on-deactivate branch May 17, 2024 10:29
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpapaspyros bpapaspyros bpapaspyros approved these changes

@eeberhard eeberhard Awaiting requested review from eeberhard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domire8 @bpapaspyros