Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify policy interval #69

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Modify policy interval #69

merged 1 commit into from
Jan 24, 2024

Conversation

kimhanbeom
Copy link
Contributor

@kimhanbeom kimhanbeom commented Jan 24, 2024

This PR is for a feature that is only used in rio projects.

  • Change the Interval/RequestedInterval enum to include the new fields.
  • Fix clippy error.
  • Bump the new rio version 0.3.1+rio.0.0.1.

- Change the `Interval`/`RequestedInterval` enum to include the new fields.
- Fix clippy error.
- Bump the new rio version 0.3.1+rio.0.0.1.
@kimhanbeom kimhanbeom requested a review from syncpark January 24, 2024 02:09
@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (00b7d7d) 4.79% compared to head (ab9c463) 4.77%.

Files Patch % Lines
src/model.rs 0.00% 3 Missing ⚠️
src/client.rs 0.00% 1 Missing ⚠️
src/subscribe.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##             rio     #69      +/-   ##
========================================
- Coverage   4.79%   4.77%   -0.02%     
========================================
  Files          7       7              
  Lines        813     816       +3     
========================================
  Hits          39      39              
- Misses       774     777       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syncpark syncpark merged commit fbd6dc6 into rio Jan 24, 2024
8 checks passed
@syncpark syncpark deleted the david/rio/modify-interval branch January 24, 2024 07:52
kimhanbeom added a commit that referenced this pull request Feb 5, 2024
- Change the `Interval`/`RequestedInterval` enum to include the new fields.
- Fix clippy error.
- Bump the new rio version 0.3.2+rio.0.0.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants