Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed configuration fields name #83

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

dayeon5470
Copy link
Contributor

@dayeon5470 dayeon5470 commented Apr 2, 2024

Fixes #82

Changed configuration fields name.

  • 'rootstoroot`.
  • giganto_ingest_address to giganto_ingest_srv_addr.
  • giganto_publish_address to giganto_publish_srv_addr.
  • review_address to review_rpc_srv_addr.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 4.53%. Comparing base (cd49d58) to head (a9e9404).

Files Patch % Lines
src/settings.rs 0.00% 10 Missing ⚠️
src/subscribe/tests.rs 0.00% 10 Missing ⚠️
src/main.rs 0.00% 8 Missing ⚠️
src/client.rs 0.00% 4 Missing ⚠️
src/request.rs 0.00% 1 Missing ⚠️
src/subscribe.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #83      +/-   ##
========================================
+ Coverage   4.51%   4.53%   +0.01%     
========================================
  Files          7       7              
  Lines        863     860       -3     
========================================
  Hits          39      39              
+ Misses       824     821       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dayeon5470 dayeon5470 force-pushed the unify_variable_name branch from 3b1f9a0 to 1dec5f7 Compare April 2, 2024 06:22
@kimhanbeom
Copy link
Contributor

@dayeon5470
https://github.com/orgs/aicers/discussions/20#discussioncomment-8990905 로 인해 필드명의 변경사항이 발생했습니다.
확인 후 다시 pr 부탁드립니다.

@kimhanbeom kimhanbeom self-requested a review April 3, 2024 04:34
@dayeon5470 dayeon5470 force-pushed the unify_variable_name branch 2 times, most recently from 1cb1ff6 to 6e1ad44 Compare April 4, 2024 00:49
@dayeon5470 dayeon5470 force-pushed the unify_variable_name branch from 6e1ad44 to a9e9404 Compare April 4, 2024 00:51
@kimhanbeom kimhanbeom self-requested a review April 4, 2024 05:00
@kimhanbeom kimhanbeom merged commit aa1621c into main Apr 4, 2024
8 checks passed
@kimhanbeom kimhanbeom deleted the unify_variable_name branch April 4, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unify the variable names that point to the same object in all progorams
3 participants