Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Add document for GraphQL API connRawEvents #918

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sophie-cluml
Copy link
Contributor

@sophie-cluml sophie-cluml commented Dec 3, 2024

Hi @sehkone, I’ve created this draft PR to ask for your confirmation if I’m heading in the right direction. So far, I’ve only worked on the connRawEvents GraphQL API as a single case example. If the approach aligns with your expectations, I can proceed to apply the same methodology to the remaining GraphQL APIs. Let me know your thoughts.

GraphQL Playground looks like below:

image

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.50%. Comparing base (57d8341) to head (7477857).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   77.50%   77.50%           
=======================================
  Files          32       32           
  Lines       26298    26298           
=======================================
  Hits        20383    20383           
  Misses       5915     5915           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

timestamp: DateTime<Utc>,
/// Source IP, or source IP address in long format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source IP address only would suffice without Source IP

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does long format means?

orig_addr: String,
/// Source port, or source port number in long format.
Copy link
Contributor

@sehkone sehkone Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source port number would suffice without Source port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants