Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Implement (Try)From trait for converting GitHub API reponse to GitHubIssue #185

@kiwon94

Description

@kiwon94

Issue Overview

Currently, converting GitHub API responses into GitHubIssue structures involves manually mapping fields, which results in verbose and less idiomatic Rust code. Additionally, this manual mapping triggers the clippy::too_many_lines warning, forcing us to add #[allow(clippy::too_many_lines)] annotations. To address this, we aim to refactor the conversion logic using the (Try)From trait.

Additionally, the current usage of unwrap_or_default needs reconsideration. Critical fields, such as the issue number used as a database key, should not use default values to avoid compromising data integrity. Identifying and handling these critical fields will also be part of this issue.

Feature Details

  • Implement the (Try)From trait for converting GitHub API response structures into GitHubIssue.
  • Ensure all relevant nested types and fields are also converted using (Try)From.
  • Identify and address critical fields where unwrap_or_default should be avoided.
  • Remove #[allow(clippy::too_many_lines)] annotation due to improved readability and reduced line count.

Expected Outcome

  • Simplified and maintainable code with clear separation of conversion logic.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions