Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More than 9 stars should be supported #16

Closed
kirsle opened this issue Feb 1, 2017 · 0 comments · Fixed by #18
Closed

More than 9 stars should be supported #16

kirsle opened this issue Feb 1, 2017 · 0 comments · Fixed by #18
Labels
bug

Comments

@kirsle
Copy link
Member

kirsle commented Feb 1, 2017

In

rivescript-go/src/tags.go

Line 222 in 7f29a68

for i := 1; i <= 9; i++ {

The JS and Java implementations support arbitrary numbers of <star> tags for as many capture groups as the trigger regexp matched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Low-hanging bugs, unit test and code restructure aichaos/rivescript-go
1 participant
@kirsle