Low-hanging bugs, unit test and code restructure #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This goes through all the code and cleans up variable names, deletes unused functions, and fixes `go vet` errors. This also adds `error` return values to Reply(), SortReplies() and CurrentUser(), and adds more helpful error conditions to LoadFile() and LoadDirectory() to catch common user mistakes. And this fixes RemoveHandler() to delete any object macros already loaded by that handler to protect against null pointer exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some of the low-hanging bugs and also restructures the code and unit tests.
For the full details on changes, see the change log for v0.1.1, which this branch will become.
Major Changes
API Change: Package
github.com/aichaos/rivescript-go/confighas been removed and instead theconfig.Configtype can be found in the root package asrivescript.Config. To migrate existing code, make these changes:import ( "github.com/aichaos/rivescript-go" - "github.com/aichaos/rivescript-go/config" ) func main() { - bot := rivescript.New(config.Config{ + bot := rivescript.New(rivescript.Config{ Debug: true, }) bot.LoadDirectory("eg/brain") }API Change: the functions
Reply(),SortReplies()andCurrentUser()returnerrorobjects now in addition to their old return values.Bugs Fixed