Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve quality aa1 #6

Merged
merged 9 commits into from
Jun 16, 2020
Merged

Improve quality aa1 #6

merged 9 commits into from
Jun 16, 2020

Conversation

Aichnerc
Copy link
Member

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change?
  • Have you tested your changes with successful results?

Type of Changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change which adds documentation)
  • Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

  • Currently our ScrollToTop fix is not implemented.
  • Currently we do not use #regions. Improve code quality #3
  • Currently there is no Prettier configuration.
  • Currently only the main mdb react pro package is being excluded from github by our .gitignore.

What is the new behavior (if this is a feature change)?

  • The ScrollToTop fix is implemented.
  • We now use #regions on all files. The code has been cleaned up. Closes Improve code quality #3
  • A prettier configuration has been added.
  • All possible future mdb pro packages are now being excluded from github by our .gitignore.

Other information:

  • The version has been updated (minor).

@Aichnerc
Improve SPDX year
65cf309 
2019-2020 -> 2020.
@Aichnerc
Add regions
b547158 
Regions have been added to all files.
@Aichnerc
Add .env.template
23ad21e 
The basic template has been created which includes version.
@Aichnerc
Add prettier config
378f090 
The config file has been created and implemented.
@Aichnerc
Update gitignore
5803ef7 
All possible MDB packages are now being excluded.
@Aichnerc Aichnerc added the enhancement New feature or request label Jun 11, 2020
@Aichnerc Aichnerc self-assigned this Jun 11, 2020
LucaAllmaier
LucaAllmaier approved these changes Jun 11, 2020
View reviewed changes
Copy link

@LucaAllmaier LucaAllmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

schettn
schettn reviewed Jun 11, 2020
View reviewed changes
src/App.js Show resolved Hide resolved
schettn
schettn approved these changes Jun 11, 2020
View reviewed changes
Copy link
Collaborator

@schettn schettn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

pinterid
pinterid reviewed Jun 11, 2020
View reviewed changes
src/App.js Show resolved Hide resolved
pinterid
pinterid reviewed Jun 11, 2020
View reviewed changes
src/App.js Show resolved Hide resolved
pinterid
pinterid reviewed Jun 11, 2020
View reviewed changes
src/index.js Show resolved Hide resolved
pinterid
pinterid suggested changes Jun 11, 2020
View reviewed changes
Copy link
Collaborator

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes have to be made.

@Aichnerc
Improve code quality
6f5bd2b 
Some useless lines has been removed,
@Aichnerc
Add formatOnSave
3e7b6e0 
The option has been added to the vscode settings.
@Aichnerc
Improve code quality
44c5a4c 
Prettier has been applied.
@Aichnerc
Improve code quality
891b1b3 
Prettier has been applied.
@Aichnerc Aichnerc requested a review from pinterid June 16, 2020 06:23
pinterid
pinterid approved these changes Jun 16, 2020
View reviewed changes
Copy link
Collaborator

@pinterid pinterid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Aichnerc Aichnerc merged commit 209433b into master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schettn schettn schettn approved these changes

@LucaAllmaier LucaAllmaier LucaAllmaier approved these changes

@pinterid pinterid pinterid approved these changes

Assignees

@Aichnerc Aichnerc

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve code quality
4 participants
@Aichnerc @schettn @pinterid @LucaAllmaier