Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting by recent comments #51

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix sorting by recent comments #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion manual-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ This is a temporary testing strategy for the tests until a more automated soluti
- Check that highlighting still works when changing from an image diff to a code diff.

### Slower tests
- Push a change to a PR and reload the page and check if they're still highlighted
- Push a change to a PR and reload the page and check if they're still highlighted
- Go to a PR with comments and sort by recent comments. Check if the highlighting is still working.