replace kubernetes_job with kubectl_manifest
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it is clear what terraform is used in replace and what terraform is used to patch. overhauled documentation/examples with .terraform-docs templates.
… issue where but the configmap does not exist. in this case, we have to execute kubectl create when it does not exist.
…rce. It is much more simple to implement. It handles create or patch. Manages the data fields correctly for paritially managed resources. Supports remote operations. kind of a win/win/win over the kubernetes job resource.
aidanmelen
changed the title
kubernetes_job with kubectl_manifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes
kubernetes_jobwithkubectl_manifest. This simplifies the module quite a bit. The provider handles create or patch functionality in a single resource. What's more, since the provider uses the k8s golang libraries, this solution also run remote operations in Terraform Cloud or in CI/CD.terraform-aws-modules/httpto ensure the cluster isACTIVEbefore thekubectl_manifestruns.test/mockfor hacky rapid testing.Upgrade Notes
You will see the
kubernetes_jobget replaced with thekubectl_manifestwhen upgrading from v0.8.3. The apply will automatically recreate theaws-authconfigmap.