Skip to content

Table rows demo continuity #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidenybai merged 12 commits into from
Feb 7, 2026
+209 −92
Merged

Table rows demo continuity #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9788a2f
Make mobile demo animation continuous with table rows
cursoragent Feb 4, 2026
f3f548a
Clean up table row animation code
cursoragent Feb 4, 2026
b1d8b58
Fix ref callback to return void for React 19
cursoragent Feb 4, 2026
9171998
Skip last table row in animation
cursoragent Feb 4, 2026
b9e2a9e
Add comment interaction for table rows in mobile demo
cursoragent Feb 4, 2026
4db9523
Fix activity row animation and concurrent loop issues
cursoragent Feb 4, 2026
3f68e35
Fix index mismatch in activity rows and fading label text bug
cursoragent Feb 4, 2026
82bfb91
Fix animation loop not restarting after visibility change
cursoragent Feb 4, 2026
5d90a36
Position table row labels above to prevent cutoff
cursoragent Feb 5, 2026
a1db779
Fix label cutoff: add bottom padding, skip last row, position below
cursoragent Feb 5, 2026
95be3d9
Make all interactions comment-based except the last one (OrderRow)
cursoragent Feb 5, 2026
c56917d
Fix flaky copy-feedback e2e test for hover during feedback period
aidenybai Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions packages/react-grab/e2e/copy-feedback.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,25 +79,16 @@ test.describe("Copy Feedback Behavior", () => {
await reactGrab.hoverElement("li:first-child");
await reactGrab.waitForSelectionBox();

const boundsBefore = await reactGrab.getSelectionBoxBounds();

await reactGrab.page.keyboard.down(reactGrab.modifierKey);
await reactGrab.page.keyboard.down("c");
await reactGrab.clickElement("li:first-child");
await reactGrab.page.waitForTimeout(100);
await reactGrab.hoverElement("h1");
await reactGrab.waitForSelectionBox();

const boundsAfter = await reactGrab.getSelectionBoxBounds();
const boundsSizeChanged =
boundsBefore &&
boundsAfter &&
(boundsBefore.width !== boundsAfter.width ||
boundsBefore.height !== boundsAfter.height);
await reactGrab.page.waitForTimeout(FEEDBACK_DURATION_MS + 500);

expect(boundsBefore).not.toBeNull();
expect(await reactGrab.isOverlayVisible()).toBe(true);
const boundsAfter = await reactGrab.getSelectionBoxBounds();
expect(boundsAfter).not.toBeNull();
expect(boundsSizeChanged).toBe(true);

await reactGrab.page.keyboard.up("c");
await reactGrab.page.keyboard.up(reactGrab.modifierKey);
Expand Down
Loading
Loading