Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installation of subpackages #190

Merged
merged 32 commits into from
Jan 11, 2025
Merged

Allow installation of subpackages #190

merged 32 commits into from
Jan 11, 2025

Conversation

johanos1
Copy link
Collaborator

@johanos1 johanos1 commented Dec 17, 2024

Description

Summary of changes

  • Defined subpackage dependencies in the toml file
  • AttackFactory now has conditional imports. (MIA required FL inputs due to everything being imported in the AttackScheduler)
  • CICD now use the toml file to create environment

The environments are now installable by:

  1. navigate to root
  • MIA: pip install -e .[mia]
  • FL: pip install -e .[federated]
  • Syn: pip install -e .[synthetic]
  • Developer: pip install -e .[dev] (this installs all packages in the above three plus testing packages)

Resolved Issues

How Has This Been Tested?

  • CICD passing
  • All examples (mia, syn, fl) pass when running in the sub-environments
  • The report handle example does not run as it require all environments...

@johanos1 johanos1 self-assigned this Dec 17, 2024
@johanos1 johanos1 requested review from fazelehh and gpadres December 17, 2024 14:23
@johanos1 johanos1 added the enhancement New feature or request label Dec 17, 2024
@johanos1 johanos1 merged commit cf89641 into main Jan 11, 2025
1 check passed
@johanos1 johanos1 deleted the subpackages branch January 11, 2025 09:13
fazelehh added a commit that referenced this pull request Jan 13, 2025
This reverts commit cf89641, reversing
changes made to f30b53a.
@fazelehh fazelehh mentioned this pull request Jan 13, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for subpackage installation
3 participants