Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radiation #105

Merged
merged 10 commits into from
Jan 31, 2023
Merged

Radiation #105

merged 10 commits into from
Jan 31, 2023

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Jan 16, 2023

Description

Summary of changes

  • Added radiation model
  • Added tests, docs for it
  • Added ability to interrupt activities and for the local_actor to die due to radiation

Resolved Issues

How Has This Been Tested?

CI, new test

Related Pull Requests

N/A

@gomezzz gomezzz added documentation Improvements or additions to documentation enhancement New feature or request tests Anything related to the tests feature implementing a new feature user-facing Anything that users can interact with physical-model All things involving some physical models labels Jan 16, 2023
GabrieleMeoni
GabrieleMeoni requested changes Jan 18, 2023
View reviewed changes
paseos/actors/actor_builder.py Outdated Show resolved Hide resolved
paseos/actors/actor_builder.py Outdated Show resolved Hide resolved
paseos/actors/actor_builder.py Outdated Show resolved Hide resolved
paseos/actors/actor_builder.py Outdated Show resolved Hide resolved
paseos/activities/activity_processor.py Outdated
# Perform final update
await self._update(elapsed_time)
# Perform final update if not interrupted before (otherwise already upto date)
if not self._paseos_instance.local_actor.was_interrupted:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you check if the device is dead as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

README.md Show resolved Hide resolved
@GabrieleMeoni
Copy link
Collaborator

Check Issue #111 for future improvements and #112 to create an example or add radiation to an example.

@gomezzz gomezzz requested a review from GabrieleMeoni January 19, 2023 17:27
@gomezzz gomezzz added the v0.1.0 Related to / Required for v0.1.0 label Jan 30, 2023
@gomezzz gomezzz mentioned this pull request Jan 30, 2023
Merged
1 task
@gomezzz gomezzz merged commit d2f2cd6 into main Jan 31, 2023
@gomezzz gomezzz deleted the radiation branch January 31, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrieleMeoni GabrieleMeoni GabrieleMeoni approved these changes

@johanos1 johanos1 Awaiting requested review from johanos1

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request feature implementing a new feature physical-model All things involving some physical models tests Anything related to the tests user-facing Anything that users can interact with v0.1.0 Related to / Required for v0.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default loglevel to "info" or "warning Radiation modeling
2 participants
@gomezzz @GabrieleMeoni