Skip to content

ggml-et: Retrieve kernel errors #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vidas wants to merge 2 commits into
base: et
Choose a base branch
from
Open

ggml-et: Retrieve kernel errors #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
715d1ec
ggml-et: Retrieve kernel errors
vidas Oct 20, 2025
d88b94c
ggml-et: Print device id
vidas Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions ggml/src/ggml-et/ggml-et-kernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,46 @@ bool ggml_et_launch_kernel(ggml_backend_et_device_context* dev_ctx, const std::s
// Wait for completion (synchronous execution)
runtime->waitForStream(dev_ctx->default_stream);

// Check for kernel execution errors
auto errors = runtime->retrieveStreamErrors(dev_ctx->default_stream);
for (const auto& error : errors) {
// Check if there are error contexts (indicates kernel-level errors)
if (error.errorContext_.has_value() && !error.errorContext_->empty()) {
bool found_kernel_error = false;

for (const auto& ctx : *error.errorContext_) {
// Type 4 = CM_CONTEXT_TYPE_USER_KERNEL_ERROR (kernel returned non-zero)
// Skip uninitialized contexts (debug fill pattern 0xcdcdcdcdcdcdcdcd)
if (ctx.type_ == 4 && ctx.hartId_ != 0xcdcdcdcdcdcdcdcdULL) {
int64_t kernel_return_code = ctx.userDefinedError_;
GGML_LOG_ERROR("ET: Kernel '%s' returned error code %lld on device %d, hart %lld (shire %lld)\n",
kernel_name.c_str(),
(long long)kernel_return_code,
dev_ctx->devidx,
(long long)ctx.hartId_,
(long long)(ctx.hartId_ / 64));
found_kernel_error = true;

// Only log first failing hart to avoid spam
break;
}
}

if (found_kernel_error) {
return false;
}
}

// Handle errors without contexts (other device-level errors)
if (error.errorCode_ != rt::DeviceErrorCode::Unknown) {
GGML_LOG_ERROR("ET: Kernel '%s' failed with device error code %d on device %d\n",
kernel_name.c_str(),
(int)error.errorCode_,
dev_ctx->devidx);
return false;
}
}

GGML_LOG_DEBUG("ET: Kernel %s completed successfully\n", kernel_name.c_str());
return true;

Expand Down