C-level output redirection on windows #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we cannot capture c-level output handler on windows. This causes an error when we when attempt to import
command.py
. Hence, I cannot ground PDDL on windows.There are two resolutions for this. The second resolution is what this pull request does.
stdout_redirect
is the context manager which requires the c-level output handlerc_stdout
, but we don't use it anywhere. Hence, we can resolve this by simply removingstdout_redirect
and the portion of code which retrieves the handler. That is, we remove everything fromtarski/src/tarski/utils/command.py
Line 72 in 80a33dc
In case, we want to keep
stdout_redirect
, I have added the code to retrieve the handler on Windows. The program would fall back to original routine ifsys.platform
is anything other thanwin32
.